Fix RuleSet.remove (#3685)

astral-sh · Mar 23, 2023 · 6161e56 · 6161e56
1 parent 189c9d4
commit 6161e56
Showing 1 changed file with 12 additions and 1 deletion.
diff --git a/crates/ruff/src/registry/rule_set.rs b/crates/ruff/src/registry/rule_set.rs
@@ -111,7 +111,7 @@ impl RuleSet {
         let mut i = 0;
 
         while i < self.0.len() {
-            self.0[i] ^= other.0[i];
+            self.0[i] &= !other.0[i];
             i += 1;
         }
 
@@ -362,4 +362,15 @@ mod tests {
         let expected_rules: Vec<_> = Rule::iter().collect();
         assert_eq!(all_rules, expected_rules);
     }
+
+    #[test]
+    fn remove_not_existing_rule_from_set() {
+        let mut set = RuleSet::default();
+
+        set.remove(Rule::AmbiguousFunctionName);
+
+        assert!(!set.contains(Rule::AmbiguousFunctionName));
+        assert!(set.is_empty());
+        assert_eq!(set.into_iter().collect::<Vec<_>>(), vec![]);
+    }
 }