-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failing on page load #2
Comments
More info. It seems to be happening on a custom element. I have a replaceable part in the custom element, and one of my uses (the one that's breaking it I think) is to make the replaceable part empty... However, after trying to fill in those empty replaceable parts, it's still a no go. |
@AStoker is this on latest Aurelia framework? Any chance of a repro too? I tested on my application, maybe you have got a use pattern that I've not come across yet that needs some edge case handling |
v0.17.0, should be. |
Yep, sounds good - ok if you can get me a minimal repro that would be useful It sounds like for some reason the viewslot's anchor is in a fragment and therefore has no parent |
Fun fact... I'm having a hard time reproducing the issue in Safari, but it always happens in Chrome. And it happens when it gets to a comment that aurelia automatically posts. Could be something with how Babel transpiles for different browsers? |
Let me retract that... Safari isn't throwing the error in the console, but I still don't see the debugger. |
https://github.com/AStoker/broken-aurelia-debugger. <tab-nav navigation.bind="router.navigation"> </tab-nav> For it to work, remove the space. <tab-nav navigation.bind="router.navigation"></tab-nav> |
Awesome, thanks for that I'll have a look in a bit and hopefully it's something trivial. |
No problem. Here's for hoping! Could very well be something trivial I'm doing wrong... |
@AStoker out of curiosity, are you finding this plugin useful? It was born from a comment Patrick Walters made on gitter... |
It has been useful. I'm coming from a KnockoutJS background, and we always had the ability to get the data context for any element by typing in the console |
@AStoker did you ever get to the bottom of this issue yourself? Sorry I've not really looked myself yet, loads going on in my neck of the woods so I was struggling... |
I haven't either, been busy with moving buildings and conferences coming up. I'm not roadblocked by this, thankfully. |
On page load I'm getting an error in the function
elementHasNamedParent
in thedom-tracker.js
file. Element is not defined, and walking up the tree it looks like the_createClass
getter is setting theelement
variable being passed down to be null (due the the propertyview.firstchild.parentElement
being null. It appears that it's looping through DOM elements, and it's hit a comment element<!--view-->
that aurelia automatically generates. Not sure if that is the actual problem, but that's what I think I'm seeing going on here.The text was updated successfully, but these errors were encountered: