Allow sync empty folders from CC to Git repo #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleso
reviewed
Mar 28, 2018
| @@ -78,6 +79,19 @@ def do_sync(self): | |||
| self.dst_root): | |||
| copied_file_count += 1 | |||
| return copied_file_count | |||
|
|
|||
| def do_sync_empty_folders(self): | |||
There was a problem hiding this comment.
If you're going to do this I wouldn't have a separate function, I would pass an argument to do_sync to avoid the duplication here.
|
@faisal-hameed Thanks for the PR. I'm not sure how I feel about this. I don't really like empty folders in git in general. The other issue is that you haven't handed the empty folders in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow syncing empty folders from CC repo to Git repo.
It will create .keep files to track empty folders in Git repo.
Related to Issue#32