Portability issue with inet_aton on FreeBSD 13.2

[mppf]

In compiling Chapel 1.31 (pre-release) on FreeBSD 13.2, I see this warning:

sys.c:124:12: warning: call to undeclared function 'inet_aton'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
    return inet_aton(host, &addr_inet->sin_addr);
           ^
1 warning generated.

I looked at a few simple things before timing out on the issue:

• #define _BSD_SOURCE does not seem to help
• adding more #includes does not seem to help.

I've created this issue to keep track of the issue and its solution.

[EduardoMorras]

To fix it change the line to use inet_pton. I use this since 1.31, Should I send a pull request?

runtime/src/qui/sys.c line 113and forward.

int sys_set_sys_sockaddr_t(sys_sockaddr_t* addr, const char* host, u_int16_t port, int family)
{
if(family == AF_INET){
struct sockaddr_in *addr_inet = (struct sockaddr_in *)&addr->addr;
addr_inet->sin_family = AF_INET;
addr_inet->sin_port = htons(port);
++ return inet_pton(AF_INET, host, &addr_inet->sin_addr);
-- return inet_aton(host, &addr_inet->sin_addr);
}

[mppf]

@EduardoMorras - thanks very much for figuring it out. Yes, a PR would be greatly appreciated.

[EduardoMorras]

PR done. Not signed.