Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a kibiter section in mordred.cfg #84

Open
jgbarah opened this issue Jan 29, 2018 · 11 comments
Open

Create a kibiter section in mordred.cfg #84

jgbarah opened this issue Jan 29, 2018 · 11 comments

Comments

@jgbarah
Copy link
Contributor

jgbarah commented Jan 29, 2018

When #80 is merged, we will have two separate kinds of information in the panels section: information about the dashboard (such as the default index pattern, or the default time period for the dashboard), and about the infrastructure supporting it (Kibiter url, for example).

I propose to split that into two sections: panels and kibiter. The first one about stuff which is directly related to the dashboard, and the second one stuff which would reflect details of the infrastructure, related to Kibiter, that could change in different deployments of the same dashboard, not affecting the dashboard itself.

For now, the new parameters introduced in #80 would come under kibiter.

@canasdiaz
Copy link
Contributor

I like the idea 👍

@valeriocos
Copy link
Member

With some delay, I like the idea! In addition, this can open the door to a better management of the panels (archimedes). @sduenas wdyt?

@canasdiaz
Copy link
Contributor

Due to we are moving to OpenDistro I would close this ticket.

@valeriocos
Copy link
Member

even if we use ODFE, Kibiter (adapted to ODFE) would always exist or I'm missing something?

@jsmanrique
Copy link

Let me clarify my view. If I want to run GrimoireLab without "Kibiter", but with a vanilla Kibana from ODFE or Elastic, what do I need Kibiter related actions (like menu set up) for?

@valeriocos
Copy link
Member

AFAIU the kibiter section should contain just the infra info (url of the instance, default index pattern). Both things are not kibiter-specific, but provided by kibana. Panels info should go to another section (panels).

@canasdiaz
Copy link
Contributor

canasdiaz commented Nov 7, 2019

Let me clarify my view. If I want to run GrimoireLab without "Kibiter", but with a vanilla Kibana from ODFE or Elastic, what do I need Kibiter related actions (like menu set up) for?

A couple of questions @jsmanrique

What does ODFE stand for?

I understand you would like to disable the menu and to enable just the upload/publication of the Kibana dashboards. Is that right?

@GeorgLink
Copy link
Sponsor Member

GeorgLink commented Nov 7, 2019 via email

@jsmanrique
Copy link

ODFE = Open Distro for Elasticsearch

That's it. Thank you @GeorgLink

AFAIK, Elasticsearch is a TM owned by Elastic, so I am trying to save words and since Elastic is suing AWS for using the name, I think it might be wise to use the acronym until the situation gets clear.

Regarding your other question @sanacl, yes, I am foreseeing a scenario where you have GrimoireLab to collect data and produce ES indexes, and potentially some reference Kibana dashboards or panels, and instead of using Kibiter container I would use my own Kibana flavor (let's say ODFE). To make it work nowadays I need to set panels phase to false, so there is no menu upload, but there is no index pattern set up neither. So, I need to go index by index creating its index pattern.

To make it more clear, I would like GrimoireLab becoming just a data generator, with the data stored in ES. But able to use other visualization tools like Kibana, Kibiter, Graphana, etc. easily.

What do you think?

@canasdiaz
Copy link
Contributor

To make it more clear, I would like GrimoireLab becoming just a data generator, with the data stored in ES. But able to use other visualization tools like Kibana, Kibiter, Graphana, etc. easily.

What do you think?

The task of allowing Mordred to have different jobs to do what you want is simple. The aim of using different visualizations tools is a wise move I think.

So, in order to do what is requested in this ticket we could:

  • split kibiter and panels phase as @jgbarah requested
  • add the menu parameters to a new section or at least move it to panels section. In both scenarios a parameter to disable it must be added

@jsmanrique
Copy link

Thank you @sanacl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants