Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage Bad Platform Tokens #1424

Closed
sgoggins opened this issue Aug 13, 2021 · 0 comments · Fixed by #1471
Closed

Manage Bad Platform Tokens #1424

sgoggins opened this issue Aug 13, 2021 · 0 comments · Fixed by #1471
Assignees
Labels
workers Related to data workers

Comments

@sgoggins
Copy link
Member

Is your feature request related to a problem? If so, please describe the problem:
When a platform API token goes bad, it returns a message :

2021-08-12 16:25:42,887,887ms [PID: 279416] workers.github_worker.57516 [INFO] Hitting endpoint: https://api.github.com/users/toufikImk ...

2021-08-12 16:25:43,170,170ms [PID: 279416] workers.github_worker.57516 [INFO] Contributor data: {'message': 'API rate limit exceeded for user ID XXXXXXX.', 'documentation_url': 'https://docs.github.com/rest/overview/resources-in-the-rest-api#rate-limiting'}

OFTEN THESE TOKENS ARE NOT ACTUALLY BAD

There are some more details in Issue #1423 about a particular instance of this happening

Potential solutions:
Goal: Create a record of each token marked bad. If it shows up regularly, then we know its bad.

Add a rejected_tokens table to the augur_operations schema. Insert a record every time we get bad_credentials returned. It does not reliably mean the credentials are bad. But if we start seeing the same token over and over again it likely is. *THIS SHOULD NOT BE VISIBLE BEFORE LOGIN IS IMPLEMENTED and it should be made visible through an AUTHENTICATED API. (Sorry for the overuse of capitalization.). ALSO: 💯

Additional context:
Issue discovered in release v0.20.1

@sgoggins sgoggins added the workers Related to data workers label Aug 13, 2021
@sgoggins sgoggins linked a pull request Oct 7, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
workers Related to data workers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants