Duplicated code for constraints in navier_stokes solver #1303
Comments
|
I can take care of it! |
11 tasks
11 tasks
blaisb
pushed a commit
that referenced
this issue
Oct 9, 2024
…1313) Description As mentioned in #1303, the constraints of the matrix free application are now mature enough to have only one common implementation for the three fluid dynamics applications: matrix-based, matrix-free and block applications. Therefore, the three main functions related to boundary conditions are now in only one place in the base class, i.e., NavierStokesBase. Testing No additional tests are included. All the existent tests pass for the three fluid dynamics applications. Documentation No documentation required for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There is a lot of duplicated code in the way constraints are managed between the navier_stokes_matrix_based, navier_stokes_block_matrix and navier_stokes_matrix_free code.
All of the constraint management could be moved to the base class and the exception handling for the few boundary conditions that are not managed correctly could be moved elsewhere. This would remove a lot of line of codes and would have prevented bug like the one I fixed in #1302 .
@lpsaavedra do you want to do it or I can take care of it :). Your call
The text was updated successfully, but these errors were encountered: