From 6f0317c5be2221406a38f9cc9be6f8cd72cca6e0 Mon Sep 17 00:00:00 2001 From: Amishga Alphonius <107414376+AmishgaAlphonius@users.noreply.github.com> Date: Mon, 4 Mar 2024 10:09:26 -0500 Subject: [PATCH] Apply suggestions from code review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Olivier Guévremont --- ...phase_change_constrain_solid_domain.output | 30 +++++++++++++++++++ ...of_phase_change_constrain_solid_domain.prm | 1 + .../parameters/cfd/constrain_stasis.rst | 2 +- include/solvers/navier_stokes_base.h | 2 +- 4 files changed, 33 insertions(+), 2 deletions(-) diff --git a/applications_tests/lethe-fluid/heat_transfer_vof_phase_change_constrain_solid_domain.output b/applications_tests/lethe-fluid/heat_transfer_vof_phase_change_constrain_solid_domain.output index ef826bea83..adf5f1f8ca 100644 --- a/applications_tests/lethe-fluid/heat_transfer_vof_phase_change_constrain_solid_domain.output +++ b/applications_tests/lethe-fluid/heat_transfer_vof_phase_change_constrain_solid_domain.output @@ -7,26 +7,56 @@ Running on 1 MPI rank(s)... Pressure drop: 0 Pa Total pressure drop: 0 Pa +--------------- +VOF Barycenter +--------------- + time x_vof y_vof vx_vof vy_vof +0.000000 0.125000 0.058681 0.000000 0.000000 + ******************************************************************************* Transient iteration: 1 Time: 0.1 Time step: 0.1 CFL: 0 ******************************************************************************* Pressure drop: -0.366978 Pa Total pressure drop: -0.366978 Pa +--------------- +VOF Barycenter +--------------- + time x_vof y_vof vx_vof vy_vof +0.100000 0.125000 0.058681 -0.000009 -0.000023 + ********************************************************************************* Transient iteration: 2 Time: 0.2 Time step: 0.1 CFL: 0.00412505 ********************************************************************************* Pressure drop: -0.367039 Pa Total pressure drop: -0.367039 Pa +--------------- +VOF Barycenter +--------------- + time x_vof y_vof vx_vof vy_vof +0.200000 0.124998 0.058682 -0.000002 0.000006 + ********************************************************************************* Transient iteration: 3 Time: 0.3 Time step: 0.1 CFL: 0.00230552 ********************************************************************************* Pressure drop: -0.367051 Pa Total pressure drop: -0.367051 Pa +--------------- +VOF Barycenter +--------------- + time x_vof y_vof vx_vof vy_vof +0.300000 0.124995 0.058684 0.000003 0.000031 + ******************************************************************************** Transient iteration: 4 Time: 0.4 Time step: 0.1 CFL: 0.0016325 ******************************************************************************** Pressure drop: -0.367145 Pa Total pressure drop: -0.367145 Pa + +--------------- +VOF Barycenter +--------------- + time x_vof y_vof vx_vof vy_vof +0.400000 0.124992 0.058687 0.000002 0.000032 diff --git a/applications_tests/lethe-fluid/heat_transfer_vof_phase_change_constrain_solid_domain.prm b/applications_tests/lethe-fluid/heat_transfer_vof_phase_change_constrain_solid_domain.prm index a4e491b857..2d16d6793a 100644 --- a/applications_tests/lethe-fluid/heat_transfer_vof_phase_change_constrain_solid_domain.prm +++ b/applications_tests/lethe-fluid/heat_transfer_vof_phase_change_constrain_solid_domain.prm @@ -164,6 +164,7 @@ subsection post-processing set verbosity = verbose set calculate pressure drop = true set calculate mass conservation = false + set calculate barycenter = true end #--------------------------------------------------- diff --git a/doc/source/parameters/cfd/constrain_stasis.rst b/doc/source/parameters/cfd/constrain_stasis.rst index 3a96e6402a..cd755b5f51 100644 --- a/doc/source/parameters/cfd/constrain_stasis.rst +++ b/doc/source/parameters/cfd/constrain_stasis.rst @@ -23,7 +23,7 @@ The subsection with default parameters goes as follows: end end -* The ``enable`` parameter is set to ``true`` when at least one temperature-dependent solid domain constraint should be applied. +* The ``enable`` parameter is set to ``true`` when at least one temperature-dependent stasis constraint should be applied. * The ``number of constraints`` parameter is an integer representing the number of constraints that will be applied. It is used in multiphase (VOF) simulations to apply different constraints to each fluid. Only one constraint per fluid can be imposed. Each constraint comes with its own subsection (starting with number ``0``) containing its own set of parameters as detailed below. diff --git a/include/solvers/navier_stokes_base.h b/include/solvers/navier_stokes_base.h index cf4ff4d311..a215a509da 100644 --- a/include/solvers/navier_stokes_base.h +++ b/include/solvers/navier_stokes_base.h @@ -59,7 +59,7 @@ using namespace dealii; /** * @brief Struct containing fluid id, temperature range information, and flag - * containers for DOFs used in temperature-dependent solid domain constraints. + * containers for DOFs used in temperature-dependent stasis constraints. * * @param[in] fluid_id Identifier of the fluid that is constrained. *