Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use standard-version, make one package, move folders #981

Merged
merged 16 commits into from
Apr 15, 2022

Conversation

jinlee93
Copy link
Contributor

@jinlee93 jinlee93 commented Apr 15, 2022

Summary:

  • merge work that's been done on publish-next to main so we can move forward with publishes as one package;
    • remove workspaces
    • use separate tsconfig for build
    • move icons to src/icons

Test Plan:

Next Steps:

  • publish v0.10.0 from main
  • deprecate eds-components and eds-tokens in npm

@jinlee93 jinlee93 marked this pull request as ready for review April 15, 2022 19:25
@jinlee93 jinlee93 requested a review from a team April 15, 2022 19:25
@codecov
Copy link

codecov bot commented Apr 15, 2022

Codecov Report

Merging #981 (bd0fe11) into main (bff502f) will increase coverage by 0.26%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #981      +/-   ##
==========================================
+ Coverage   95.78%   96.04%   +0.26%     
==========================================
  Files         140      141       +1     
  Lines        1138     1213      +75     
  Branches      173      173              
==========================================
+ Hits         1090     1165      +75     
  Misses         47       47              
  Partials        1        1              
Impacted Files Coverage Δ
lib/tokens/ts/colors.ts 100.00% <ø> (ø)
src/components/Banner/Banner.stories.tsx 75.00% <ø> (ø)
src/components/Button/button.stories.tsx 91.30% <ø> (ø)
src/components/Button/button.tsx 100.00% <ø> (ø)
src/components/Button/index.ts 100.00% <ø> (ø)
src/components/ButtonGroup/ButtonGroup.stories.tsx 100.00% <ø> (ø)
src/components/ButtonGroup/ButtonGroup.tsx 75.00% <ø> (ø)
src/components/Checkbox/Checkbox.stories.tsx 88.46% <ø> (ø)
src/components/Checkbox/Checkbox.tsx 100.00% <ø> (ø)
src/components/Checkbox/index.ts 100.00% <ø> (ø)
... and 412 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bff502f...bd0fe11. Read the comment docs.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

size-limit report

Path Size
components 72.88 KB (+1.68% 🔺)
styles 5.45 KB (+17.71% 🔺)

Copy link
Contributor

@anniehu4 anniehu4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@@ -0,0 +1,58 @@
## Versioning
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's rename this file to docs/PUBLISHING.md

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 I swore I did that in the other pr but a wrinkle in my brain must have smoothened itself, will do

@jinlee93 jinlee93 merged commit ccc0450 into main Apr 15, 2022
@jinlee93 jinlee93 deleted the publish-next branch April 15, 2022 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants