Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove lerna and use standard-version to publish v0.10 #979

Merged
merged 5 commits into from
Apr 15, 2022
Merged

feat: remove lerna and use standard-version to publish v0.10 #979

merged 5 commits into from
Apr 15, 2022

Conversation

jinlee93
Copy link
Contributor

@jinlee93 jinlee93 commented Apr 15, 2022 •
edited
Loading

[sc-187216]
[sc-189730]

Summary:

Test Plan:

Next steps:

  • After merge, publish actual v0.10?
  • Deprecate eds-components and eds-tokens in npm

@jinlee93 jinlee93 requested a review from a team April 15, 2022 05:36
jinlee93
jinlee93 commented Apr 15, 2022
View reviewed changes
scripts/updateYarnLockForLerna.sh
Comment on lines -1 to -20
#!/bin/sh

# Abort this script if any commands fail.
set -e

# Currently (August, 2021), Lerna does not update yarn.lock files when dependencies between
# monorepo packages increment. See https://github.com/lerna/lerna/issues/1171. This causes failures
# on CI builds because of the `--immutable` flag we use when installing deps on CI, since Yarn
# wants to update the lock file for the updated inter-package dependencies.
#
# To work around that, we manually install deps so that the lock file gets updated. This should run
# in a Lerna "version" lifecycle hook. See https://github.com/lerna/lerna/tree/a47fc294393a3e9507a8207a5a2f07648a524722/commands/version#lifecycle-scripts.
#
# Another workaround would be to use Yarn workspace ranges to specify dependencies between
# packages. See https://yarnpkg.com/features/workspaces/#workspace-ranges-workspace.
# Unfortunately, Lerna also doesn't support those - https://github.com/lerna/lerna/issues/2564.
#
# If either of these Lerna issues are resolved, we should remove this hack.
yarn install
git stage yarn.lock
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this file is needed anymore since Lerna not used

jinlee93
jinlee93 commented Apr 15, 2022
View reviewed changes
docs/publishing.md Outdated
Comment on lines 31 to 32
3. Run `yarn` to ensure all dependencies are upto date.
4. Run `yarn build` to build EDS.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we just have yarn build in the release scripts?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah that's a good idea 👍 lerna might have been doing that automatically

jinlee93
jinlee93 commented Apr 15, 2022
View reviewed changes
docs/publishing.md
@@ -0,0 +1,48 @@
## Versioning
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure where to place this doc other than here.
Could consider displaying it in storybook like BM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this works! I think convention is to capitalize docs file names -> docs/PUBLISHING.md

@shortcut-integration
Copy link

This pull request has been linked to:

anniehu4
anniehu4 approved these changes Apr 15, 2022
View reviewed changes
Copy link
Contributor

@anniehu4 anniehu4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet, thanks!

docs/publishing.md
@@ -0,0 +1,48 @@
## Versioning
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this works! I think convention is to capitalize docs file names -> docs/PUBLISHING.md

docs/publishing.md Outdated
Comment on lines 31 to 32
3. Run `yarn` to ensure all dependencies are upto date.
4. Run `yarn build` to build EDS.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah that's a good idea 👍 lerna might have been doing that automatically

@codecov
Copy link

codecov bot commented Apr 15, 2022 •
edited
Loading

Codecov Report

Merging #979 (3697a63) into publish-next (b0314fa) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           publish-next     #979   +/-   ##
=============================================
  Coverage         96.11%   96.11%           
=============================================
  Files               144      144           
  Lines              1209     1209           
  Branches            171      171           
=============================================
  Hits               1162     1162           
  Misses               46       46           
  Partials              1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0314fa...3697a63. Read the comment docs.

@jinlee93 jinlee93 merged commit 7812949 into publish-next Apr 15, 2022
@jinlee93 jinlee93 deleted the jlee/publish-eds-v10 branch April 15, 2022 17:08
jinlee93 added a commit that referenced this pull request Apr 15, 2022
@jinlee93 @anniehu4 @ahuth
build: use standard-version, make one package, move folders (#981)
ccc0450 
* chore: move packages/tokens to src/tokens

* chore: publish to lib/tokens

BREAKING CHANGE: removes color-font tokens

* remove typo

Co-authored-by: Andrew Huth <[email protected]>

* chore: move packages/components to src/components

* chore: remove token package imports

* chore: consolidate into one package.json

* chore: cleanup docs, remove workspaces

* feat: lock headlessui to 1.4.3

* chore: clean up imports

* build: use separate tsconfig for build

* build: publish icons

* feat: move components/Icons to src/icons

* feat(publishing): remove lerna and use standard-version to publish v0.10 (#979)

* feat: add standard-version, remove lerna, update storybook

* chore(release): 0.10.0-alpha.0

* docs(publishing): make publishing readme

* docs(readme): update readme to link publishing doc

* docs(publishing): add 'yarn build' to script commands and document

* docs: capitalize publishing doc file

Co-authored-by: Annie Hu <[email protected]>
Co-authored-by: Andrew Huth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anniehu4 anniehu4 anniehu4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jinlee93 @anniehu4