feat: introduce badges addon for storybook #895
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
size-limit report
| Path | Size |
|---|---|
| components | 72.4 KB (0%) |
| styles | 4.47 KB (0%) |
| }, | ||
| beta: { | ||
| ...defaultBadgesConfig[BADGE.BETA], | ||
| tooltip: { |
There was a problem hiding this comment.
nit: could we remove the tooltips for now, until we find a use for them? 🙂
There was a problem hiding this comment.
I'm down for removing the tooltips, mostly to show configuration possibility
|
|
||
| const Example = () => <p>Example to show badges addon</p>; | ||
|
|
||
| export default { |
There was a problem hiding this comment.
Is this mostly for internal documentation? Would suggest naming it title: "Documentation/BadgesAddon" (or once we merge with next, adding to one of the comprehensive docs files there)
oh derp just saw your comment -- removing before merge also works
Codecov Report
@@ Coverage Diff @@
## main #895 +/- ##
=======================================
Coverage 95.85% 95.85%
=======================================
Files 143 143
Lines 1134 1134
Branches 171 171
=======================================
Hits 1087 1087
Misses 46 46
Partials 1 1 Continue to review full report at Codecov.
|
|
@jinlee93 This is awesome, thanks! When you feel good about this (looks like there's a little cleanup), would you mind also getting this setup into |
* feat: introduce badges addon for storybook * chore: remove badge tooltip config * chore: remove temp example story
Summary:
deprecatedorbeta, wouldn't need badge otherwise?Test Plan: