chore: upgrade style-dictionary #882
Conversation
CHANGELOG.md
Outdated
|
|
||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
not sure if we commit the alpha releases, can revert
There was a problem hiding this comment.
If the alpha was only for testing the change, I think reverting makes sense. Could imagine keeping alpha releases around if we're building upon a big branch or something
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
size-limit report
| Path | Size |
|---|---|
| components | 71.99 KB (0%) |
| styles | 4.47 KB (0%) |
| @@ -18,7 +18,7 @@ | |||
| "url": "git+https://github.com/chanzuckerberg/edu-design-system.git" | |||
| }, | |||
| "scripts": { | |||
| "build": "style-dictionary build --config=./style-dictionary.config.js", | |||
| "build": "node ./style-dictionary.config.js", | |||
There was a problem hiding this comment.
since we're not using the json config, should have been doing this to begin with. (also errors in compile in v3) https://amzn.github.io/style-dictionary/#/using_the_npm_module
| @@ -3,7 +3,7 @@ const EDSStyleDictionary = StyleDictionary.extend({ | |||
| source: ["properties/**/*.json"], | |||
| platforms: { | |||
| scss: { | |||
| transforms: [...StyleDictionary.transformGroup.scss, "name/kebabCase"], | |||
| transforms: [...StyleDictionary.transformGroup.scss, "name/cti/kebab"], | |||
CHANGELOG.md
Outdated
|
|
||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
If the alpha was only for testing the change, I think reverting makes sense. Could imagine keeping alpha releases around if we're building upon a big branch or something
| @@ -18,7 +18,7 @@ | |||
| "url": "git+https://github.com/chanzuckerberg/edu-design-system.git" | |||
| }, | |||
| "scripts": { | |||
| "build": "style-dictionary build --config=./style-dictionary.config.js", | |||
| "build": "node ./style-dictionary.config.js", | |||
|
looks good, pending removing the alpha release changes! |
This reverts commit f5658f9.
Codecov Report
@@ Coverage Diff @@
## main #882 +/- ##
=======================================
Coverage 95.83% 95.83%
=======================================
Files 142 142
Lines 1128 1128
Branches 171 171
=======================================
Hits 1081 1081
Misses 46 46
Partials 1 1 Continue to review full report at Codecov.
|
Summary:
Test Plan: