-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: disable dependabot version updates #873
Conversation
Codecov Report
@@ Coverage Diff @@
## main #873 +/- ##
=======================================
Coverage 95.83% 95.83%
=======================================
Files 142 142
Lines 1128 1128
Branches 171 171
=======================================
Hits 1081 1081
Misses 46 46
Partials 1 1 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
size-limit report
Path | Size |
---|---|
components | 69.34 KB (0%) |
styles | 4.44 KB (0%) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
size-limit report
Path | Size |
---|---|
components | 69.34 KB (0%) |
styles | 4.4 KB (0%) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
commit-message: | ||
prefix: chore | ||
include: scope | ||
- package-ecosystem: npm | ||
directory: "/packages/components" | ||
schedule: | ||
interval: daily | ||
open-pull-requests-limit: 10 | ||
# dependabot does not work with yarn v2, disabling for now | ||
open-pull-requests-limit: 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we delete this file and not even run the job?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had hope that one day dependabot would fix this issue and then we could edit the config to work better :')
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
size-limit report
Path | Size |
---|---|
components | 71.95 KB (0%) |
styles | 4.47 KB (0%) |
Summary:
https://app.shortcut.com/czi-edu/story/183913/figure-out-what-to-do-with-dependabot
All dependabot version update PRs fail the build (example) because dependabot does not support yarn v2
this turns off the PRs (which we did, and then un-did awhile ago)
Test Plan:
not sure how to test, I followed https://docs.github.com/en/code-security/supply-chain-security/keeping-your-dependencies-updated-automatically/enabling-and-disabling-dependabot-version-updates#disabling-dependabot-version-updates