feat: add Dropdown component #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #835 +/- ##
==========================================
+ Coverage 95.75% 95.83% +0.07%
==========================================
Files 139 142 +3
Lines 1013 1128 +115
Branches 138 171 +33
==========================================
+ Hits 970 1081 +111
- Misses 43 46 +3
- Partials 0 1 +1
Continue to review full report at Codecov.
|
dierat
commented
Feb 3, 2022
ghost
reviewed
Feb 4, 2022
ghost
self-requested a review
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
size-limit report
| Path | Size |
|---|---|
| components | 70.34 KB (+2.58% 🔺) |
| styles | 4.45 KB (+0.16% 🔺) |
dierat
force-pushed
the
diedra/dropdown/add
branch
from
baf0966 to
48f05d9
Compare
ghost
approved these changes
Feb 7, 2022
dierat
force-pushed
the
diedra/dropdown/add
branch
from
48f05d9 to
290eba6
Compare
There was a problem hiding this comment.
size-limit report
| Path | Size |
|---|---|
| components | 70.83 KB (+3.26% 🔺) |
| styles | 4.46 KB (+0.38% 🔺) |
There was a problem hiding this comment.
size-limit report
| Path | Size |
|---|---|
| components | 70.89 KB (+3.34% 🔺) |
| styles | 4.46 KB (+0.38% 🔺) |
There was a problem hiding this comment.
size-limit report
| Path | Size |
|---|---|
| components | 71.12 KB (+3.65% 🔺) |
| styles | 4.46 KB (+0.38% 🔺) |
There was a problem hiding this comment.
size-limit report
| Path | Size |
|---|---|
| components | 71.31 KB (+3.61% 🔺) |
| styles | 4.46 KB (+0.38% 🔺) |
There was a problem hiding this comment.
size-limit report
| Path | Size |
|---|---|
| components | 71.3 KB (+3.59% 🔺) |
| styles | 4.46 KB (+0.38% 🔺) |
dierat
force-pushed
the
diedra/dropdown/add
branch
from
895ef1b to
b29e5fd
Compare
There was a problem hiding this comment.
size-limit report
| Path | Size |
|---|---|
| components | 71.31 KB (+3.61% 🔺) |
| styles | 4.46 KB (+0.38% 🔺) |
dierat
force-pushed
the
diedra/dropdown/add
branch
from
5de074e to
8fbdf84
Compare
There was a problem hiding this comment.
size-limit report
| Path | Size |
|---|---|
| components | 71.95 KB (+3.64% 🔺) |
| styles | 4.52 KB (+1.67% 🔺) |
anniehu4
approved these changes
Feb 25, 2022
There was a problem hiding this comment.
size-limit report
| Path | Size |
|---|---|
| components | 71.95 KB (+3.64% 🔺) |
| styles | 4.47 KB (+1.69% 🔺) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Part of https://app.shortcut.com/czi-edu/story/169970/dropdown-api-improvements
Dropdowncomponent intraject: https://github.com/FB-PLP/traject/blob/master/app/assets/javascripts/v2/core/EDSCandidates/Dropdown/Dropdown.tsxTest Plan:
Test in storybook, verify the snapshots look good, tested in
trajectwith an alpha build.