feat: add DropdownButton #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
size-limit report
| Path | Size |
|---|---|
| components | 65.44 KB (+1.89% 🔺) |
| styles | 4.38 KB (0%) |
Codecov Report
@@ Coverage Diff @@
## main #804 +/- ##
==========================================
+ Coverage 95.84% 95.89% +0.05%
==========================================
Files 132 134 +2
Lines 938 950 +12
Branches 125 125
==========================================
+ Hits 899 911 +12
Misses 39 39
Continue to review full report at Codecov.
|
dierat
force-pushed
the
diedra/dropdown-button/add
branch
from
c4779a3 to
5975ba1
Compare
dierat
commented
Jan 25, 2022
packages/components/src/index.ts
Outdated
| @@ -2,6 +2,7 @@ export { default as Banner } from "./Banner"; | |||
| export { default as Button } from "./Button"; | |||
| export { default as Checkbox } from "./Checkbox"; | |||
| export { default as ClickableStyle } from "./ClickableStyle"; | |||
| export { default as DropdownButton } from "./ClickableStyle"; | |||
dierat
commented
Jan 25, 2022
packages/components/package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@chanzuckerberg/eds-components", | |||
| "version": "0.5.0", | |||
| "version": "0.5.1-alpha.3", | |||
There was a problem hiding this comment.
uh wait I need to remove this
There was a problem hiding this comment.
size-limit report
| Path | Size |
|---|---|
| components | 65.44 KB (+1.9% 🔺) |
| styles | 4.38 KB (0%) |
There was a problem hiding this comment.
size-limit report
| Path | Size |
|---|---|
| components | 66.66 KB (+1.87% 🔺) |
| styles | 4.44 KB (0%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Clubhouse ticket: https://app.shortcut.com/czi-edu/story/169593/dropdownbutton-move-to-eds
DropdownButtonintraject: https://github.com/FB-PLP/traject/tree/c5e16483f7e199696b7dc32ed6e4350428edc6eb/app/assets/javascripts/v2/core/EDSCandidates/DropdownButtonCopies the
DropdownButtoncomponent fromtraject. Please note we're not pulling over the wholeDropdowncomponent just yet because there are a few changes we want to make to the API first.Test Plan:
traject'sDropdowncomponent in storybook using version0.5.1-alpha.4