fix(Fieldset): fix label typography #2137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add temporary shim to the label style to match InputField - document as HACK to address later (remove FieldLabel?) - update snapshots
|
Before and after: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2137 +/- ##
=======================================
Coverage 96.92% 96.92%
=======================================
Files 114 114
Lines 2923 2925 +2
Branches 800 801 +1
=======================================
+ Hits 2833 2835 +2
Misses 86 86
Partials 4 4 ☔ View full report in Codecov by Sentry. |
size-limit report 📦
|
Merged
booc0mtaco
added a commit
that referenced
this pull request
Feb 28, 2025
## [15.11.0](v15.10.2...v15.11.0) (2025-02-28) [Storybook](https://61313967cde49b003ae2a860-axnxgwyyxf.chromatic.com/) ### Features * **DataTable:** export sort direction enum with types ([#2133](#2133)) ([a0948d6](a0948d6)) * **icon:** add thumb-up-and-down ([#2136](#2136)) ([2c2202a](2c2202a)) * **scripts:** add local mode ([#2135](#2135)) ([965a579](965a579)) * **scripts:** allow import script to pull using Figma API ([#2132](#2132)) ([5919b30](5919b30)) ### Bug Fixes * **Fieldset:** fix label typography ([#2137](#2137)) ([624b757](624b757))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Plan: