-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(SelectionChip): introduce 1.0 component #2112
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2112 +/- ##
==========================================
+ Coverage 97.09% 97.11% +0.01%
==========================================
Files 110 112 +2
Lines 2788 2806 +18
Branches 758 763 +5
==========================================
+ Hits 2707 2725 +18
Misses 77 77
Partials 4 4 ☔ View full report in Codecov by Sentry. |
size-limit report 📦
|
booc0mtaco
force-pushed
the
aholloway/EDS-1444
branch
2 times, most recently
from
December 3, 2024 21:27
2324c3e
to
2df8ff9
Compare
Screen.Recording.2024-12-03.at.15.29.31.mov |
booc0mtaco
force-pushed
the
aholloway/EDS-1444
branch
from
December 3, 2024 21:33
2df8ff9
to
f11b934
Compare
- support event and state handling - support transition states for when selected - implement design API - add tests and snapshots
booc0mtaco
force-pushed
the
aholloway/EDS-1444
branch
from
December 3, 2024 21:37
f11b934
to
f68032d
Compare
timzchang
approved these changes
Dec 4, 2024
Merged
booc0mtaco
added a commit
that referenced
this pull request
Dec 11, 2024
## [15.8.0](v15.7.0...v15.8.0) (2024-12-11) [Storybook](https://61313967cde49b003ae2a860-ryfsqaioup.chromatic.com/) ### Features * **SelectionChip:** introduce 1.0 component ([#2112](#2112)) ([6d4a3f4](6d4a3f4))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Plan: