Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SelectionChip): introduce 1.0 component #2112

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Conversation

booc0mtaco
Copy link
Contributor

Test Plan:

  • Wrote/updated automated tests
  • CI tests / new tests are not applicable
  • Manually tested my changes, and here are the details:

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.11%. Comparing base (f205e07) to head (898714a).
Report is 1 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2112      +/-   ##
==========================================
+ Coverage   97.09%   97.11%   +0.01%     
==========================================
  Files         110      112       +2     
  Lines        2788     2806      +18     
  Branches      758      763       +5     
==========================================
+ Hits         2707     2725      +18     
  Misses         77       77              
  Partials        4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 2, 2024

size-limit report 📦

Path Size
components 94.59 KB (+0.78% 🔺)
styles 29.67 KB (+1.09% 🔺)

@booc0mtaco booc0mtaco marked this pull request as draft December 2, 2024 22:59
@booc0mtaco booc0mtaco force-pushed the aholloway/EDS-1444 branch 2 times, most recently from 2324c3e to 2df8ff9 Compare December 3, 2024 21:27
@booc0mtaco booc0mtaco marked this pull request as ready for review December 3, 2024 21:30
@booc0mtaco
Copy link
Contributor Author

Screen.Recording.2024-12-03.at.15.29.31.mov

@booc0mtaco booc0mtaco requested a review from a team December 3, 2024 21:35
- support event and state handling
- support transition states for when selected
- implement design API
- add tests and snapshots
src/components/SelectionChip/SelectionChip.tsx Outdated Show resolved Hide resolved
@booc0mtaco booc0mtaco merged commit 6d4a3f4 into next Dec 4, 2024
12 checks passed
@booc0mtaco booc0mtaco deleted the aholloway/EDS-1444 branch December 4, 2024 23:53
@booc0mtaco booc0mtaco mentioned this pull request Dec 11, 2024
booc0mtaco added a commit that referenced this pull request Dec 11, 2024
## [15.8.0](v15.7.0...v15.8.0) (2024-12-11)

[Storybook](https://61313967cde49b003ae2a860-ryfsqaioup.chromatic.com/)

### Features

* **SelectionChip:** introduce 1.0 component ([#2112](#2112)) ([6d4a3f4](6d4a3f4))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants