Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Button): specify size for enabled/disabled buttons #2063

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

booc0mtaco
Copy link
Contributor

  • separate out the size metrics from the internal size styles
  • regenerate snapshots for comparison
  • add story for showing disabled buttons at all sizes

Test Plan:

  • Wrote/updated automated tests
  • CI tests / new tests are not applicable
  • Manually tested my changes, and here are the details:

@booc0mtaco booc0mtaco requested a review from a team September 27, 2024 20:55
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.06%. Comparing base (eadbcd0) to head (9740185).
Report is 2 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2063   +/-   ##
=======================================
  Coverage   97.05%   97.06%           
=======================================
  Files         111      111           
  Lines        2752     2756    +4     
  Branches      728      732    +4     
=======================================
+ Hits         2671     2675    +4     
  Misses         78       78           
  Partials        3        3           
Flag Coverage Δ
97.06% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Sep 27, 2024

size-limit report 📦

Path Size
components 92.46 KB (+0.02% 🔺)
styles 28.73 KB (+0.1% 🔺)

- separate out the size metrics from the internal size styles
- regenerate snapshots for comparison
- add story for showing disabled buttons at all sizes
@booc0mtaco booc0mtaco force-pushed the aholloway/x-fix-disabled-button-styles branch from 4a82495 to 9740185 Compare September 27, 2024 21:06
Copy link

@sskikne sskikne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@booc0mtaco
Copy link
Contributor Author

Thanks @sskikne ! (the size thing is a quirk on the button component right now, which I wanna clean up. having styles suffixed --prop-value is the general pattern, but this was the first component we did when building 2.0 and hadn't figured that out yet)

@booc0mtaco booc0mtaco merged commit 39f3af6 into next Oct 1, 2024
10 checks passed
@booc0mtaco booc0mtaco deleted the aholloway/x-fix-disabled-button-styles branch October 1, 2024 16:28
@booc0mtaco booc0mtaco mentioned this pull request Oct 4, 2024
booc0mtaco added a commit that referenced this pull request Oct 5, 2024
### [15.4.1](v15.4.0...v15.4.1) (2024-10-04)

[Storybook](https://61313967cde49b003ae2a860-ffjofyjbkx.chromatic.com/)

### Bug Fixes

* **Button:** specify size for enabled/disabled buttons ([#2063](#2063)) ([39f3af6](39f3af6))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants