feat: export ClickableStyleProps #1860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #1860 +/- ##
=======================================
Coverage 92.59% 92.59%
=======================================
Files 148 148
Lines 2862 2862
Branches 780 780
=======================================
Hits 2650 2650
Misses 195 195
Partials 17 17 ☔ View full report in Codecov by Sentry. |
ahuth
force-pushed
the
ah-clickable-style-props
branch
3 times, most recently
from
a5cfb07 to
5ac4f0c
Compare
size-limit report 📦
|
ahuth
force-pushed
the
ah-clickable-style-props
branch
4 times, most recently
from
256f941 to
5cd2b89
Compare
Usages in our Remix apps will not need to deeply import anymore (in fact,
they cannot with Vite due to how the bundling works)
- import type {ClickableStyleProps} from "@chanzuckerberg/eds/lib/components/ClickableStyle";
+ import type {ClickableStyleProps} from "@chanzuckerberg/eds";
We need the ClickableStyleProps for our custom Remix Link component, so
we properly integrate the Remix and EDS Link components.
Re-exporting the props is easier to work with. The deep import in edu-stack was always a hack.
ahuth
force-pushed
the
ah-clickable-style-props
branch
from
5cd2b89 to
9c4ab11
Compare
Merged
booc0mtaco
added a commit
that referenced
this pull request
Mar 4, 2024
## [13.12.0](v13.11.0...v13.12.0) (2024-03-04) [Storybook](https://61313967cde49b003ae2a860-telsscxlak.chromatic.com/?path=/docs/getting-started--docs) ### Features * export ClickableStyleProps ([#1860](#1860)) ([0d1b49e](0d1b49e)) * **Select:** add support for required in overline ([#1855](#1855)) ([6e44566](6e44566)) ### Bug Fixes * lodash tree shaking ([#1852](#1852)) ([f55f9cb](f55f9cb)) * **Select:** add max height for Select.Options ([#1858](#1858)) ([24ed8bc](24ed8bc))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Export
ClickableStylePropsfrom the top-levelindex.ts.Usages in our Remix apps won't need to deeply import anymore (in fact, they can't with Vite due to how module resolution works)
We need the
ClickableStylePropsfor our custom Remix Link component, so we properly integrate the Remix and EDS Link components.Re-exporting the props from the top-level index.ts is easier to work with. The deep import edu-stack uses was always a hack.