fix(Select): set trigger type to button to prevent submits #1843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- when a button is in a form tag, it automatically becomes able to submit - our wrapper doesn't include this which is usually fine - sometimes during a slow load, the handler preventing propagation allows submit - fixing this by adding a non-editable type
size-limit report 📦
|
|
It looks like the tag properly includes this attribute, but since its related to some racing condition, not exactly sure we can get a failing state to appear |
ghost
approved these changes
Feb 8, 2024
Yeah there's not really a ticket with "steps to reproduce". The fix seems good though |
Merged
booc0mtaco
added a commit
that referenced
this pull request
Feb 20, 2024
## [13.11.0](v13.11.0-alpha.0...v13.11.0) (2024-02-20) [Storybook](https://61313967cde49b003ae2a860-xfzakymyle.chromatic.com/) ### Features * **script:** add import from figma script ([#1844](#1844)) ([9ed90e5](9ed90e5)) * **Select:** enable multi-select ([ced70d5](ced70d5)) * **Select:** add handling for long text in select field ([7c79a6e](7c79a6e)) ### Bug Fixes * **PopoverListItem:** adjust size of list item when selected ([0496f56](0496f56)) * **Select:** set trigger type to button to prevent submits ([#1843](#1843)) ([d7ea037](d7ea037))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Test Plan: