Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(InlineNotification): remove deprecated variants #1833

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

booc0mtaco
Copy link
Contributor

Summary:

  • remove yield variant from stories
  • remove inactive from stories
  • mark yield variant and inactive prop as deprecated

Test Plan:

  • n/a (documentation-only changes)

@booc0mtaco booc0mtaco requested a review from a team January 17, 2024 23:29
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8067082) 92.50% compared to head (ab6adb0) 92.46%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1833      +/-   ##
==========================================
- Coverage   92.50%   92.46%   -0.04%     
==========================================
  Files         147      147              
  Lines        2761     2761              
  Branches      740      740              
==========================================
- Hits         2554     2553       -1     
  Misses        192      192              
- Partials       15       16       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jan 17, 2024

size-limit report 📦

Path Size
components 97.68 KB (0%)
styles 39.76 KB (0%)

- remove yield variant from stories
- remove inactive from stories
- mark yield variant and inactive prop as deprecated
@booc0mtaco booc0mtaco merged commit cfcf1fa into next Jan 18, 2024
8 checks passed
@booc0mtaco booc0mtaco deleted the aholloway/EFI-1543 branch January 18, 2024 19:04
@booc0mtaco booc0mtaco mentioned this pull request Jan 19, 2024
booc0mtaco added a commit that referenced this pull request Jan 19, 2024
## [13.9.0](v13.8.1...v13.9.0) (2024-01-19)

[Storybook](https://61313967cde49b003ae2a860-utfzotmwuw.chromatic.com/)

### Features

* **Avatar:** adjust typography usages and sizing for icons ([#1830](#1830)) ([7da31e6](7da31e6))
* **InlineNotification:** remove deprecated variants ([#1833](#1833)) ([cfcf1fa](cfcf1fa))
* **Label:** mark optional as deprecated ([#1832](#1832)) ([8067082](8067082))
* **tokens:** output token literal values in a new tailwind config file ([#1828](#1828)) ([08fa1c4](08fa1c4))


### Bug Fixes

* **InputField:** mark unused prop as deprecated ([#1831](#1831)) ([622abfb](622abfb))
* **Select:** update incorrect documentation ([#1825](#1825)) ([94aace5](94aace5))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants