fix(Select): update incorrect documentation #1825
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #1825 +/- ##
=======================================
Coverage 92.50% 92.50%
=======================================
Files 147 147
Lines 2760 2760
Branches 739 739
=======================================
Hits 2553 2553
Misses 191 191
Partials 16 16 ☔ View full report in Codecov by Sentry. |
size-limit report 📦
|
| argTypes: { | ||
| multiple: { | ||
| table: { | ||
| disable: null, | ||
| }, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Was this breaking the storybook from rendering? Or just disabling because that arg doesn't work well with storybook UI?
There was a problem hiding this comment.
Hiding this one b/c we will have a forthcoming component for handling multiple selection and didn't want to have this lingering prop visible. More work to do, but closing a documentation mismatch for the moment.
|
I'll try to coerce storybook into showing a better type table so that one can see the types for
|
- update the types listed for value and defaultValue - add in proper description for generated form fields based on key/value info - hide a field from the documentation table that is currently non-fuctional
booc0mtaco
force-pushed
the
aholloway/EFI-1515
branch
from
3e7a7d3 to
77fb2ce
Compare
|
|
## [13.9.0](v13.8.1...v13.9.0) (2024-01-19) [Storybook](https://61313967cde49b003ae2a860-utfzotmwuw.chromatic.com/) ### Features * **Avatar:** adjust typography usages and sizing for icons ([#1830](#1830)) ([7da31e6](7da31e6)) * **InlineNotification:** remove deprecated variants ([#1833](#1833)) ([cfcf1fa](cfcf1fa)) * **Label:** mark optional as deprecated ([#1832](#1832)) ([8067082](8067082)) * **tokens:** output token literal values in a new tailwind config file ([#1828](#1828)) ([08fa1c4](08fa1c4)) ### Bug Fixes * **InputField:** mark unused prop as deprecated ([#1831](#1831)) ([622abfb](622abfb)) * **Select:** update incorrect documentation ([#1825](#1825)) ([94aace5](94aace5))
Summary:
Test Plan:
edu-stackortrajectas a sanity check if changes affect build or deploy, or are breaking, such as token changes, widely used component updates, hooks changes, and major dependency upgrades.