Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove duplicate addon-docs loading #1816

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

booc0mtaco
Copy link
Contributor

@booc0mtaco booc0mtaco commented Dec 6, 2023

Summary:

The docs addon comes pre-installed with storybook 7.x, so we don't need to install it or configure it directly. This clears up that duplicate install and use (which also cleans up some small output from the console when starting storybook. Slightly quicker now.

As it's now pre-installed, we also don't have to worry about keeping it up to date anymore.

Screenshot 2023-12-05 at 16 12 06

Test Plan:

  • Wrote automated tests
  • CI tests / new tests are not applicable
  • Manually tested my changes, but I want to keep the details secret
  • Manually tested my changes, and here are the details:
    • verify the "Docs" tab works normally on build in CI

@booc0mtaco booc0mtaco requested a review from a team as a code owner December 6, 2023 00:13
Copy link

github-actions bot commented Dec 6, 2023

size-limit report 📦

Path Size
components 98 KB (0%)
styles 39.75 KB (0%)

@booc0mtaco booc0mtaco merged commit 42a634c into next Dec 6, 2023
5 checks passed
@booc0mtaco booc0mtaco deleted the aholloway/x-simplify-storybook-addon-docs branch December 6, 2023 00:50
@booc0mtaco
Copy link
Contributor Author

@ahuth thanks !

@booc0mtaco booc0mtaco mentioned this pull request Dec 6, 2023
booc0mtaco added a commit that referenced this pull request Dec 6, 2023
## [13.8.0](v13.7.1...v13.8.0) (2023-12-06)

[Storybook](https://61313967cde49b003ae2a860-efutgeaecb.chromatic.com/)

### Features

* separate `ClickableStyles` from core components ([#1759](#1759)) ([c7fc2af](c7fc2af))
* **Tag:** mark yield color variant as deprecated ([#1815](#1815)) ([bd14083](bd14083))


### Bug Fixes

* remove duplicate addon-docs loading ([#1816](#1816)) ([42a634c](42a634c))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants