Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Tag): mark yield color variant as deprecated #1815

Merged
merged 1 commit into from
Dec 5, 2023
Merged

feat(Tag): mark yield color variant as deprecated #1815

merged 1 commit into from
Dec 5, 2023

Conversation

booc0mtaco
Copy link
Contributor

@booc0mtaco booc0mtaco commented Dec 5, 2023 •
edited
Loading

Summary:

  • After syncing with design, will remove this variant from the component, and lean toward warning instead
  • update corresponding snapshots

Test Plan:

  • Wrote automated tests
  • CI tests / new tests are not applicable
  • Manually tested my changes, but I want to keep the details secret
  • Manually tested my changes, and here are the details:

@booc0mtaco
feat(Tag): mark yield color variant as deprecated
11a9631 
- update corresponding snapshots
@booc0mtaco booc0mtaco requested a review from a team December 5, 2023 19:28
@codecov Codecov
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c7fc2af) 92.49% compared to head (11a9631) 92.49%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #1815   +/-   ##
=======================================
  Coverage   92.49%   92.49%           
=======================================
  Files         147      147           
  Lines        2759     2759           
  Branches      741      741           
=======================================
  Hits         2552     2552           
  Misses        191      191           
  Partials       16       16

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023

size-limit report 📦

Path Size
components 98 KB (0%)
styles 39.75 KB (0%)

@booc0mtaco booc0mtaco merged commit bd14083 into next Dec 5, 2023
6 checks passed
@booc0mtaco booc0mtaco deleted the aholloway/EFI-1476 branch December 5, 2023 21:15
@booc0mtaco booc0mtaco mentioned this pull request Dec 6, 2023
Merged
booc0mtaco added a commit that referenced this pull request Dec 6, 2023
@booc0mtaco
Merge pull request #1817 from chanzuckerberg/release-v13.8.0
3b08e63 
## [13.8.0](v13.7.1...v13.8.0) (2023-12-06)

[Storybook](https://61313967cde49b003ae2a860-efutgeaecb.chromatic.com/)

### Features

* separate `ClickableStyles` from core components ([#1759](#1759)) ([c7fc2af](c7fc2af))
* **Tag:** mark yield color variant as deprecated ([#1815](#1815)) ([bd14083](bd14083))


### Bug Fixes

* remove duplicate addon-docs loading ([#1816](#1816)) ([42a634c](42a634c))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahuth ahuth ahuth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@booc0mtaco @ahuth