feat(Avatar): add in expanded size range #1734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- support for xs, xl, xxl, and xxxl
Codecov Report
@@ Coverage Diff @@
## next #1734 +/- ##
==========================================
- Coverage 92.32% 92.28% -0.04%
==========================================
Files 146 146
Lines 2579 2579
Branches 665 665
==========================================
- Hits 2381 2380 -1
Misses 183 183
- Partials 15 16 +1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
size-limit report 📦
|
ghost
approved these changes
Sep 6, 2023
ghost
reviewed
Sep 6, 2023
Comment on lines
+78
to
+79
| height: calc(var(--eds-size-base-unit) * 20); | ||
| width: calc(var(--eds-size-base-unit) * 20); |
There was a problem hiding this comment.
Is this just because there is no --eds-size-20?
There was a problem hiding this comment.
correct. I didn't want to create a token for that yet since we might move to t-shirt sizes instead of fixed constants
Merged
booc0mtaco
added a commit
that referenced
this pull request
Sep 7, 2023
## [13.2.0](v13.1.1...v13.2.0) (2023-09-07) ### Features * **Avatar:** add in expanded size range ([#1734](#1734)) ([7af6e5e](7af6e5e)) * **tokens:** add tooling for EDS theming ([#1738](#1738)) ([91497bf](91497bf)) ### Bug Fixes * opt our rollup CJS build into TS's module interop behavior ([#1747](#1747)) ([2b0855e](2b0855e))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Test Plan: