Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(icons): make icons rounded outline and add send, mail #1669

Merged
merged 5 commits into from
Jun 28, 2023
Merged

feat(icons): make icons rounded outline and add send, mail #1669

merged 5 commits into from
Jun 28, 2023

Conversation

jinlee93
Copy link
Contributor

@jinlee93 jinlee93 commented Jun 27, 2023 •
edited by jira bot
Loading

EDS-1043

Summary:

  • for Along we're changing material icons from sharp to rounded outline
  • also adding send and mail icons since these have utility non specific to Along and we already have similar icons such as print
  • need one sync with design to finalize some q's

Test Plan:

  • icon set matches mocks
  • components with swapped icons look fine in snaps

@jinlee93 jinlee93 requested a review from a team June 27, 2023 09:00
@codecov
Copy link

codecov bot commented Jun 27, 2023 •
edited
Loading

Codecov Report

Merging #1669 (95f4dc2) into next (1fe0e6c) will increase coverage by 93.23%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##           next    #1669       +/-   ##
=========================================
+ Coverage      0   93.23%   +93.23%     
=========================================
  Files         0      222      +222     
  Lines         0     2969     +2969     
  Branches      0      721      +721     
=========================================
+ Hits          0     2768     +2768     
- Misses        0      184      +184     
- Partials      0       17       +17
Impacted Files Coverage Δ
src/icons/spritemap.tsx 100.00% <ø> (ø)
src/components/Avatar/Avatar.tsx 86.95% <100.00%> (ø)

... and 220 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Jun 27, 2023 •
edited
Loading

size-limit report 📦

Path Size
components 111.98 KB (+17.54% 🔺)
styles 36.55 KB (0%)

booc0mtaco
booc0mtaco approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@booc0mtaco booc0mtaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a straightforward swap. Interesting and expected that the rounded icons have more complex paths given all the radii at the edges.

@jinlee93 jinlee93 merged commit 669d01c into next Jun 28, 2023
@jinlee93 jinlee93 deleted the jlee/roundedOutlineIcons branch June 28, 2023 18:35
@booc0mtaco booc0mtaco mentioned this pull request Jun 29, 2023
Merged
booc0mtaco added a commit that referenced this pull request Jun 29, 2023
@booc0mtaco
Merge pull request #1670 from chanzuckerberg/release-v12.3.0
a0469b1 
## [12.3.0](v12.2.0...v12.3.0) (2023-06-29)


### Features

* **breadcrumbs:** allow custom separators ([#1663](#1663)) ([1fe0e6c](1fe0e6c))
* **button:** create t3 token for border radius ([#1665](#1665)) ([eadd005](eadd005))
* **icons:** make icons rounded outline and add send, mail ([#1669](#1669)) ([669d01c](669d01c))
* **tokens:** add t2 color bg-brand-primary-subtle ([#1668](#1668)) ([7137da6](7137da6))
* **typography:** support typography theming ([#1664](#1664)) ([3148751](3148751))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@booc0mtaco booc0mtaco booc0mtaco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jinlee93 @booc0mtaco