-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: group all font imports together #1615
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- removing the font import from mixin caused Open Sans to stop appearing in storybook - similar to Graphik, we should import the fonts from our fonts.css file - existing instructions won't need changing, as they specify using this file already
Codecov Report
@@ Coverage Diff @@
## next #1615 +/- ##
==========================================
- Coverage 91.32% 91.32% -0.01%
==========================================
Files 280 280
Lines 4196 4195 -1
Branches 789 789
==========================================
- Hits 3832 3831 -1
Misses 338 338
Partials 26 26
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
size-limit report 📦
|
This was referenced May 16, 2023
jinlee93
reviewed
May 16, 2023
jinlee93
reviewed
May 16, 2023
jinlee93
approved these changes
May 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
I think our Chromatic setting to do TurboSnaps meant that it didn't detect this change as a snapshot diff, so there was no clue the font had disappeared :(
Busted snapshots start appearing later: #1613, #1614
More long term, we should revisit getting fonts from google anyway
Test Plan: