Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: group all font imports together #1615

Merged
merged 1 commit into from
May 16, 2023

Conversation

booc0mtaco
Copy link
Contributor

Summary:

  • removing the font import from mixins caused Open Sans to stop appearing in storybook
  • similar to Graphik, we should import the fonts from our fonts.css file
  • existing instructions won't need changing, as they specify using this file already (README, storybook, etc.)

I think our Chromatic setting to do TurboSnaps meant that it didn't detect this change as a snapshot diff, so there was no clue the font had disappeared :(

Busted snapshots start appearing later: #1613, #1614

More long term, we should revisit getting fonts from google anyway

Test Plan:

  • Wrote automated tests
  • CI tests / new tests are not applicable
  • Manually tested my changes, but I want to keep the details secret
  • Manually tested my changes, and here are the details:
    • verify lib/ contents are correct:
    • no import lines in index.css
    • import for google font in fonts.css
    • no snapshot updates for typography page

- removing the font import from mixin caused Open Sans to stop appearing in storybook
- similar to Graphik, we should import the fonts from our fonts.css file
- existing instructions won't need changing, as they specify using this file already
@booc0mtaco booc0mtaco requested a review from a team May 16, 2023 14:34
@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Merging #1615 (8eefa78) into next (5d8ee97) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             next    #1615      +/-   ##
==========================================
- Coverage   91.32%   91.32%   -0.01%     
==========================================
  Files         280      280              
  Lines        4196     4195       -1     
  Branches      789      789              
==========================================
- Hits         3832     3831       -1     
  Misses        338      338              
  Partials       26       26              
Impacted Files Coverage Δ
src/index.ts 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@booc0mtaco
Copy link
Contributor Author

Before (12.0.2) and after (next):
Screenshot 2023-05-16 at 09 36 05
Screenshot 2023-05-16 at 09 35 41

@github-actions
Copy link

size-limit report 📦

Path Size
components 94.5 KB (0%)
styles 36.32 KB (-0.04% 🔽)

src/index.ts Show resolved Hide resolved
Copy link
Contributor

@jinlee93 jinlee93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@booc0mtaco booc0mtaco merged commit 405027a into next May 16, 2023
@booc0mtaco booc0mtaco deleted the aholloway/x-relocate-fonts-import branch May 16, 2023 19:49
@booc0mtaco booc0mtaco mentioned this pull request May 19, 2023
booc0mtaco added a commit that referenced this pull request May 20, 2023
### [12.0.3](v12.0.2...v12.0.3) (2023-05-19)


### Bug Fixes

* clean component statuses and tokens ([#1616](#1616)) ([ebc2b36](ebc2b36))
* correct misspelled color token names ([#1618](#1618)) ([88b1f8b](88b1f8b))
* group all font imports together ([#1615](#1615)) ([405027a](405027a))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants