Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include tailwind config in package #1576

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Conversation

ahuth
Copy link
Contributor

@ahuth ahuth commented Apr 1, 2023

Summary:

In #1568 I converted the tailwind.config.js to typescript, but forgot to update the files entry to include the TS version in the package 😐.

So now consuming apps can no longer access the EDS tailwind config to get theme variables.

This PR fixes that.

Test Plan:

  • Wrote automated tests
  • CI tests / new tests are not applicable
  • Manually tested my changes, but I want to keep the details secret
  • Manually tested my changes, and here are the details:
    • npm publish --dry-run

@ahuth ahuth requested a review from a team April 1, 2023 11:59
@codecov
Copy link

codecov bot commented Apr 1, 2023

Codecov Report

Merging #1576 (121447e) into next (8c63e84) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             next    #1576   +/-   ##
=======================================
  Coverage   91.63%   91.63%           
=======================================
  Files         279      279           
  Lines        4267     4267           
  Branches      776      776           
=======================================
  Hits         3910     3910           
  Misses        331      331           
  Partials       26       26           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Apr 1, 2023

size-limit report 📦

Path Size
components 118.67 KB (0%)
styles 3.12 KB (0%)

@ahuth ahuth force-pushed the ah-fix-tailwind-config branch from 7b4ccca to 121447e Compare April 3, 2023 11:57
@ahuth
Copy link
Contributor Author

ahuth commented Apr 3, 2023

Thanks

@ahuth ahuth changed the title Fix tailwind config fix: include tailwind config in package Apr 3, 2023
@ahuth ahuth merged commit 4f66b35 into next Apr 3, 2023
@ahuth ahuth deleted the ah-fix-tailwind-config branch April 3, 2023 15:04
@booc0mtaco
Copy link
Contributor

@ahuth since the previous change was in v11.1.0, I think we should do a patch release to include this fix? i can do that in a bit

@ahuth
Copy link
Contributor Author

ahuth commented Apr 3, 2023

since the previous change was in v11.1.0, I think we should do a patch release to include this fix? i can do that in a bit

Patch release is right. Thanks! Let me know if there's anything I can do to support.

@booc0mtaco booc0mtaco mentioned this pull request Apr 3, 2023
booc0mtaco added a commit that referenced this pull request Apr 3, 2023
### [11.1.1](v11.1.0...v11.1.1) (2023-04-03)


### Bug Fixes

* include tailwind config in package ([#1576](#1576)) ([4f66b35](4f66b35))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants