feat(Button): use LoadingIndicator for loading state #1552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
- replace the inline icon (loading) with our <LoadingIndicator /> - update snapshots to account for this - don't use the visible prop, as this breaks ARIA for buttons - marking prop as deprecated since it can be handled thru composition (like arrow)
booc0mtaco
force-pushed
the
aholloway/EDS-778
branch
from
89d6c15 to
c03903d
Compare
jinlee93
reviewed
Mar 20, 2023
| /> | ||
| )} | ||
|
|
||
| {loading && <LoadingIndicator className="eds-is-loading" size="sm" />} |
There was a problem hiding this comment.
When do you think this variant will be removed? Just not a fan of this eds-is-loading classnaming haha should be more BEM
There was a problem hiding this comment.
Let's chat about it this week. we could do whenever, but removing is technically breaking, so didn't want to commit to a v12 just yet :)
agreed on that class and this implementation 🪓
jinlee93
approved these changes
Mar 20, 2023
|
@jinlee93 Thanks! we can chat this week to see what the coming week has in store w.r.t. publishable changes |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
loadingas deprecated (we will direct people and designers to compose instead, like we do with icons)Test Plan: