refactor(text)!: fully remove spacing and text passage variants #1492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
February 3, 2023 12:34
Codecov Report
@@ Coverage Diff @@
## jlee/twPreflight #1492 +/- ##
====================================================
- Coverage 91.99% 91.89% -0.11%
====================================================
Files 272 272
Lines 4136 4121 -15
Branches 727 722 -5
====================================================
- Hits 3805 3787 -18
- Misses 329 332 +3
Partials 2 2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
booc0mtaco
reviewed
Feb 10, 2023
| <Text as="div" className="!mb-8"> | ||
| <p>There are no more available projects to create your course plan</p> | ||
| <Text className="mb-8 max-w-xl"> | ||
| There are no more available projects to create your course plan |
There was a problem hiding this comment.
As part of the Cookbook RFC work, we will review such stories and make the text and such more generic (and use that FPO block)
There was a problem hiding this comment.
Super down for that
jinlee93
force-pushed
the
jlee/removeTextVariants
branch
from
65c35a4 to
a878af3
Compare
booc0mtaco
approved these changes
Feb 10, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[EDS-837]
Summary:
spacingandas="div"text passage variants<LayoutLinelengthContainer>which just applied max width of 36 rem, replaced with classNamemax-w-xlTest Plan: