Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Popover)!: remove showArrow from popover #1461

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

booc0mtaco
Copy link
Contributor

Summary:

  • after discussion with design, will remove the example showing the (already deprecated) showArrow prop

Test Plan:

  • update test snapshots

@booc0mtaco booc0mtaco requested a review from a team January 12, 2023 22:06
@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Merging #1461 (f824514) into next (b77e354) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             next    #1461      +/-   ##
==========================================
- Coverage   91.74%   91.73%   -0.01%     
==========================================
  Files         293      293              
  Lines        4359     4355       -4     
  Branches      779      777       -2     
==========================================
- Hits         3999     3995       -4     
  Misses        333      333              
  Partials       27       27              
Impacted Files Coverage Δ
src/components/Popover/Popover.stories.tsx 87.50% <ø> (-0.50%) ⬇️
src/components/Popover/Popover.tsx 94.59% <ø> (-0.41%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

children: (
<>
<Popover.Button as={Button}>Open Popover</Popover.Button>
<Popover.Content showArrow>
Copy link

@ghost ghost Jan 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the showArrow prop be removed as well?

Edit: actually you're probably keeping that prop for functionality until it is completely removed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, I think it would be ok to axe the showArrow prop and the couple usages in the recipes, since it's not being used downstream

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's fair. in fact, our 8.0 will mostly be trimming away components/props, so we can capture that in the next release and avoid creating a 9.0 JUST for this prop removal

@booc0mtaco booc0mtaco force-pushed the eds-794-remove-popover-story branch from 951360c to f824514 Compare January 17, 2023 17:56
@booc0mtaco booc0mtaco changed the title docs(Popover): remove story showing arrow usage refactor(Popover)!: remove showArrow from popover Jan 17, 2023
@booc0mtaco booc0mtaco merged commit 07396ff into next Jan 17, 2023
@booc0mtaco booc0mtaco deleted the eds-794-remove-popover-story branch January 17, 2023 18:18
@booc0mtaco booc0mtaco mentioned this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants