Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react console warning on master #926

Closed
bkmartinjr opened this issue Sep 18, 2019 · 4 comments · Fixed by #1038
Closed

react console warning on master #926

bkmartinjr opened this issue Sep 18, 2019 · 4 comments · Fixed by #1038
Assignees
@seve
Labels
bug
Milestone
0.13.0

Comments

@bkmartinjr
Copy link
Contributor

since annotations commit, getting this on load.

react-dom.development.js:11494 Warning: componentWillReceiveProps has been renamed, and is not recommended for use. See https://fb.me/react-async-component-lifecycle-hooks for details.

* Move data fetching code or side effects to componentDidUpdate.
* If you're updating state whenever props change, refactor your code to use memoization techniques or move it to static getDerivedStateFromProps. Learn more at: https://fb.me/react-derived-state
* Rename componentWillReceiveProps to UNSAFE_componentWillReceiveProps to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder.

Please update the following components: Blueprint3.Dialog, Blueprint3.Popover, Blueprint3.QueryList, Blueprint3.Suggest
@bkmartinjr bkmartinjr added the bug label Sep 18, 2019
@bkmartinjr bkmartinjr added this to the 0.12.0 milestone Sep 18, 2019
@bkmartinjr bkmartinjr changed the title console error on master react console warning on master Sep 18, 2019
@colinmegill
Copy link
Contributor

See: palantir/blueprint#2384

@colinmegill colinmegill modified the milestones: 0.12.0, 0.13.0 Sep 25, 2019
@seve
Copy link
Contributor

seve commented Oct 2, 2019

Fix was just merged in palantir/blueprint#3702

@seve
Copy link
Contributor

seve commented Oct 9, 2019

https://github.com/palantir/blueprint/wiki/3.x-Changelog Fix is live

@bkmartinjr
Copy link
Contributor Author

@seve - feel free to grab and fix if you are up for it!

@colinmegill colinmegill assigned seve and unassigned colinmegill Nov 4, 2019
@seve seve mentioned this issue Nov 13, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seve seve

Labels
bug
Projects
None yet
Milestone
0.13.0
Development

Successfully merging a pull request may close this issue.

bump @blueprintjs dependencies chanzuckerberg/cellxgene
3 participants
@colinmegill @bkmartinjr @seve