Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difference between stripAnsi and Node core #5

Closed
SBoudrias opened this issue Jul 17, 2015 · 4 comments
Closed

Difference between stripAnsi and Node core #5

SBoudrias opened this issue Jul 17, 2015 · 4 comments

Comments

@SBoudrias
Copy link

Looks like Node updated their ansi regex to also match VT control characters https://github.com/nodejs/io.js/blob/master/lib/readline.js#L974-L980

Should we do the same here?

@Qix-
Copy link
Member

Qix- commented Jul 17, 2015

Not sure if we're including them as it stands, or not. Can you get a list of them?

@Qix-
Copy link
Member

Qix- commented Aug 24, 2015

I looked over their regex again and nothing stands out that shows theirs supports any more than this one does. In fact, ours seems to support more (namely, CSI isn't always \x1b - theirs doesn't account for that).

Going to close this unless there is something I missed :) Thanks for the heads up!

@Qix- Qix- closed this as completed Aug 24, 2015
@sindresorhus
Copy link
Member

@Qix- Could you open an issue on Node.js about (namely, CSI isn't always \x1b - theirs doesn't account for that).?

@Qix-
Copy link
Member

Qix- commented Aug 24, 2015

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants