Skip to content

Conversation

@Cellule
Copy link
Contributor

@Cellule Cellule commented Dec 9, 2016

Put the WebAssembly errors in it own section to keep them all close together


This change is Reviewable

@Cellule Cellule force-pushed the users/micfer/wasm/errors branch from c56fddf to c974ee3 Compare December 9, 2016 22:09
@Cellule
Copy link
Contributor Author

Cellule commented Dec 12, 2016

@meg-gupta could you take a look at this ?

Copy link
Contributor

@meg-gupta meg-gupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cellule
Copy link
Contributor Author

Cellule commented Dec 12, 2016

@dotnet-bot test Windows x86_debug please
@dotnet-bot test Windows x86_test please

@chakrabot chakrabot merged commit c974ee3 into chakra-core:release/1.4 Dec 12, 2016
chakrabot pushed a commit that referenced this pull request Dec 12, 2016
Merge pull request #2180 from Cellule:users/micfer/wasm/errors

Put the WebAssembly errors in it own section to keep them all close together
@Cellule Cellule deleted the users/micfer/wasm/errors branch December 12, 2016 22:26
chakrabot pushed a commit that referenced this pull request Dec 12, 2016
Merge pull request #2180 from Cellule:users/micfer/wasm/errors

Put the WebAssembly errors in it own section to keep them all close together
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants