Skip to content

Commit

Permalink
[1.8>1.9] [MERGE #4650 @MikeHolman] fix issue where memop may scan fo…
Browse files Browse the repository at this point in the history
…r missing values even if not in head segment

Merge pull request #4650 from MikeHolman:missingmemop

This may cause us to incorrectly set `HasNoMissingValues(false);`

OS: 15399206
  • Loading branch information
MikeHolman committed Feb 9, 2018
2 parents f1a6b10 + d58844e commit da37507
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/Runtime/Library/JavascriptArray.inl
Original file line number Diff line number Diff line change
Expand Up @@ -989,7 +989,7 @@ SECOND_PASS:
CopyArray(current->elements + endIndex + 1, endSeg->length,
((Js::SparseArraySegment<T>*)endSeg)->elements, endSeg->length);
LinkSegments((Js::SparseArraySegment<T>*)startPrev, current);
if (HasNoMissingValues())
if (current == head && HasNoMissingValues())
{
if (ScanForMissingValues<T>(endIndex + 1, endIndex + growby))
{
Expand Down

0 comments on commit da37507

Please sign in to comment.