Disable RecyclerWatsonTelemetry + Use RDTSC for GetTickCount

Brings ~4% perf improvement [ http-load test, measured on xplat ]

- Disables RecyclerWatsonTelemetry for ChakraCore
  [ reduces the number of calls to system clock api <=~1.5% ]

- Use RDTSC for GetTickCount.
  [ this affects only xplat <=~3% ]

Author: obastemur

Build/Chakra.Build.props

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
 <Project DefaultTargets="Build" ToolsVersion="12.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
-  <Import Project="Common.Build.props"/>  
+  <Import Project="Common.Build.props"/>
   <PropertyGroup>
     <Win32_WinNTVersion Condition="'$(NtTargetVersion)'=='$(NtTargetVersion_Win7)'">0x0601</Win32_WinNTVersion>
     <Win32_WinNTVersion Condition="'$(NtTargetVersion)'=='$(NtTargetVersion_Win8)'">0x0602</Win32_WinNTVersion>
@@ -18,7 +18,8 @@
         %(PreprocessorDefinitions);
         _WIN32_WINNT=$(Win32_WinNTVersion);
         WINVER=$(Win32_WinNTVersion);
-        WIN32_LEAN_AND_MEAN=1
+        WIN32_LEAN_AND_MEAN=1;
+        TARGET_CHAKRACORE
       </PreprocessorDefinitions>
       <PreprocessorDefinitions Condition="'$(BuildJIT)'=='false'">
         %(PreprocessorDefinitions);

CMakeLists.txt

@@ -332,6 +332,7 @@ add_subdirectory (pal)
 add_definitions(
     -DNO_PAL_MINMAX
     -DPAL_STDCPP_COMPAT
+    -DTARGET_CHAKRACORE
     )
 add_subdirectory (lib)
 add_subdirectory (bin)

lib/Common/Memory/Recycler.cpp

@@ -242,7 +242,9 @@ Recycler::Recycler(AllocationPolicyManager * policyManager, IdleDecommitPageAllo
 #ifdef HEAP_ENUMERATION_VALIDATION
     ,pfPostHeapEnumScanCallback(nullptr)
 #endif
+#ifndef TARGET_CHAKRACORE
     , telemetryBlock(&localTelemetryBlock)
+#endif
 #ifdef ENABLE_JS_ETW
     ,bulkFreeMemoryWrittenCount(0)
 #endif
@@ -321,7 +323,9 @@ Recycler::Recycler(AllocationPolicyManager * policyManager, IdleDecommitPageAllo
     this->inDetachProcess = false;
 #endif
 
+#ifndef TARGET_CHAKRACORE
     memset(&localTelemetryBlock, 0, sizeof(localTelemetryBlock));
+#endif
 
 #ifdef ENABLE_DEBUG_CONFIG_OPTIONS
     // recycler requires at least Recycler::PrimaryMarkStackReservedPageCount to function properly for the main mark context
@@ -3426,8 +3430,10 @@ Recycler::Collect()
 
     {
         RECORD_TIMESTAMP(initialCollectionStartTime);
+#ifndef TARGET_CHAKRACORE
         this->telemetryBlock->initialCollectionStartProcessUsedBytes = PageAllocator::GetProcessUsedBytes();
         this->telemetryBlock->exhaustiveRepeatedCount = 0;
+#endif
 
         return DoCollectWrapped(finalFlags);
     }
@@ -3554,7 +3560,9 @@ Recycler::DoCollect(CollectionFlags flags)
     {
         INC_TIMESTAMP_FIELD(exhaustiveRepeatedCount);
         RECORD_TIMESTAMP(currentCollectionStartTime);
+#ifndef TARGET_CHAKRACORE
         this->telemetryBlock->currentCollectionStartProcessUsedBytes = PageAllocator::GetProcessUsedBytes();
+#endif
 
 #if ENABLE_CONCURRENT_GC
         // DisposeObject may call script again and start another GC, so we may still be in concurrent GC state
@@ -6910,7 +6918,7 @@ Recycler::FillCheckPad(void * address, size_t size, size_t alignedAllocSize, boo
     }
 }
 
-void 
+void
 Recycler::FillPadNoCheck(void * address, size_t size, size_t alignedAllocSize, bool objectAlreadyInitialized)
 {
     // Ignore the first word
@@ -8187,4 +8195,3 @@ RecyclerHeapObjectInfo::GetSize() const
 }
 
 template char* Recycler::AllocWithAttributesInlined<(Memory::ObjectInfoBits)32, false>(size_t);
-

lib/Common/Memory/Recycler.h

@@ -1009,9 +1009,10 @@ class Recycler
 #if DBG || defined(RECYCLER_STATS)
     bool isForceSweeping;
 #endif
+#ifndef TARGET_CHAKRACORE
     RecyclerWatsonTelemetryBlock localTelemetryBlock;
     RecyclerWatsonTelemetryBlock * telemetryBlock;
-
+#endif
 #ifdef RECYCLER_STATS
     RecyclerCollectionStats collectionStats;
     void PrintHeapBlockStats(char16 const * name, HeapBlock::HeapBlockType type);
@@ -1072,7 +1073,9 @@ class Recycler
     void LogMemProtectHeapSize(bool fromGC);
 
     char* Realloc(void* buffer, DECLSPEC_GUARD_OVERFLOW size_t existingBytes, DECLSPEC_GUARD_OVERFLOW size_t requestedBytes, bool truncate = true);
+#ifndef TARGET_CHAKRACORE
     void SetTelemetryBlock(RecyclerWatsonTelemetryBlock * telemetryBlock) { this->telemetryBlock = telemetryBlock; }
+#endif
 
     void Prime();
 

lib/Common/Memory/RecyclerWatsonTelemetry.h

@@ -2,6 +2,13 @@
 // Copyright (C) Microsoft. All rights reserved.
 // Licensed under the MIT license. See LICENSE.txt file in the project root for full license information.
 //-------------------------------------------------------------------------------------------------------
+#ifdef TARGET_CHAKRACORE
+
+#define RECORD_TIMESTAMP(Field)
+#define INC_TIMESTAMP_FIELD(Field)
+#define AUTO_TIMESTAMP(Field)
+
+#else // CHAKRA_FULL
 namespace Memory
 {
     /*
@@ -46,3 +53,4 @@ namespace Memory
         DWORD exhaustiveRepeatedCount;
     };
 };
+#endif

lib/Runtime/Base/ThreadContext.cpp

@@ -178,7 +178,9 @@ ThreadContext::ThreadContext(AllocationPolicyManager * allocationPolicyManager,
 #endif
     dynamicObjectEnumeratorCacheMap(&HeapAllocator::Instance, 16),
     //threadContextFlags(ThreadContextFlagNoFlag),
+#ifndef TARGET_CHAKRACORE
     telemetryBlock(&localTelemetryBlock),
+#endif
     configuration(enableExperimentalFeatures),
     jsrtRuntime(nullptr),
     propertyMap(nullptr),
@@ -248,7 +250,9 @@ ThreadContext::ThreadContext(AllocationPolicyManager * allocationPolicyManager,
     this->threadId = ::GetCurrentThreadId();
 #endif
 
+#ifndef TARGET_CHAKRACORE
     memset(&localTelemetryBlock, 0, sizeof(localTelemetryBlock));
+#endif
 
     AutoCriticalSection autocs(ThreadContext::GetCriticalSection());
     ThreadContext::LinkToBeginning(this, &ThreadContext::globalListFirst, &ThreadContext::globalListLast);

lib/Runtime/Base/ThreadContext.h

@@ -204,11 +204,13 @@ class IProjectionContextMemoryInfo abstract
 #endif
 #endif
 
+#ifndef TARGET_CHAKRACORE
 struct ThreadContextWatsonTelemetryBlock
 {
     FILETIME lastScriptStartTime;
     FILETIME lastScriptEndTime;
 };
+#endif
 
 class NativeLibraryEntryRecord
 {
@@ -781,8 +783,10 @@ class ThreadContext sealed :
     typedef JsUtil::BaseDictionary<Js::DynamicType const *, void *, HeapAllocator, PowerOf2SizePolicy> DynamicObjectEnumeratorCacheMap;
     DynamicObjectEnumeratorCacheMap dynamicObjectEnumeratorCacheMap;
 
+#ifndef TARGET_CHAKRACORE
     ThreadContextWatsonTelemetryBlock localTelemetryBlock;
     ThreadContextWatsonTelemetryBlock * telemetryBlock;
+#endif
 
     NativeLibraryEntryRecord nativeLibraryEntry;
 
@@ -1014,7 +1018,9 @@ class ThreadContext sealed :
     ThreadConfiguration const * GetConfig() const { return &configuration; }
 
 public:
+#ifndef TARGET_CHAKRACORE
     void SetTelemetryBlock(ThreadContextWatsonTelemetryBlock * telemetryBlock) { this->telemetryBlock = telemetryBlock; }
+#endif
 
     static ThreadContext* GetContextForCurrentThread();