Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.5 broke assert.deepEqual #139

Closed
steida opened this issue Feb 4, 2013 · 1 comment
Closed

Version 1.5 broke assert.deepEqual #139

steida opened this issue Feb 4, 2013 · 1 comment

Comments

@steida
Copy link

steida commented Feb 4, 2013

Fatal error: expected { Object (presenter, params, ...) } to deeply equal { Object (presenter, params, ...) }

Switching back to ~1.4 version solved it.

@logicalparadox
Copy link
Member

This is probably a result of #120. In short, it is possible that your deep equal assertion was providing a false-positive pass because chai did not take all enumerable properties into account. This was a necessary change and you will need to update your tests to be more specific in regards to what equality means between your two objects.

If you do think that the fix described above is not what is causing this, please re-open this issue and provide us any information you can so we can duplicate and refine our deep equality algorithm in future versions. Also, more information about your testing environment would also be helpful.

I will update ReleaseNotes.md with this explanation as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants