Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapper git server In Express #5

Open
2 of 4 tasks
cgilly2fast opened this issue Sep 23, 2019 · 6 comments
Open
2 of 4 tasks

Wrapper git server In Express #5

cgilly2fast opened this issue Sep 23, 2019 · 6 comments
Assignees

Comments

@cgilly2fast
Copy link
Owner

cgilly2fast commented Sep 23, 2019

This integration will wrap our node-git-server in an express server with CORS integration.

Located: gitServer/index.js

The server is intended to be run locally on a computer for users to push too.

See this comment in an issue in node-git server as a starting point. It lays out the basic structure of a node-git-server being used with express.

Outcome

  • 1. Developers must be able to push/pull to from a git remote from the command line.
  • 2 .The remote will have the following format: [serverURL]/projects/[Project_Owner]/[Project_Name].git
  • 3. Must maintain the ability to output data to the user's command line on “push” and “fetch” (line 39 and 49 in gitServer/index.js on express-ts-git-server branch)
  • 4. Query and read in username and password from command line like GitHub does when authenticating push access to a repo

**Work on branch: express-ts-git-server

See as Reference
Node-git-server: Documentation Source Code

@reo4
Copy link

reo4 commented Sep 23, 2019

i tried the solution in the comment and i searched a lot about running two apps on the same port but i didn't find any solution

seconed and forth requirements done , it remains the third one

@reo4
Copy link

reo4 commented Sep 23, 2019

access denied to make push

@cgilly2fast
Copy link
Owner Author

cgilly2fast commented Sep 23, 2019

I am going to move "Remove redundancy with 2 running servers into one." to a different issue.

Right now there is a server located in endpoints/index.ts and another server in gitServer/index.js

Ultimately we want these to be one file. endpoints/index.ts needs to be completely redone because it is based off of Firestore and EOS. So lets update these files separately then integrate them together.

If we collapse them now we will run into a lot of extra bugs.

Regarding push access, sense this project intended to be an open-source project, to make a contribution, fork the project, make all edits/commits on the fork, Then when it's done, create a pull request to merge your changes with the master project.

The fork, will allow you to work fast and allow me to view the code before it gets added to the main project.

Here is a video that goes over the process, you can skip the middle part where his explaining the git commands.

@cgilly2fast
Copy link
Owner Author

Here is link to some an issue thread that may be helpful.

@reo4
Copy link

reo4 commented Sep 24, 2019

i will try this : https://www.npmjs.com/package/express-git
tell me your opinion ?

@cgilly2fast
Copy link
Owner Author

I will look into it.

Please add CORS, you can see an example if needed in endpoints/index.ts

I just added reading the user name and password from the command line to the outcomes.

If we can achieve outcome 3 then we can probably just use nodejs readline() for completing outcome 4 .

Open to whatever makes sense.

https://nodejs.org/api/readline.html.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants