Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a notification plugin #158

Closed
gcrahay opened this issue Jan 13, 2017 · 2 comments
Closed

Adding a notification plugin #158

gcrahay opened this issue Jan 13, 2017 · 2 comments

Comments

@gcrahay
Copy link
Contributor

gcrahay commented Jan 13, 2017

I've created a third-party plugin named fir_async to send notifications when an incident is created or updated.

These notifications are sent via email and/or XMPP, but new methods can be easily added.

I am planning to add more events:

  • Artifact added
  • Artifact detached
  • Incident status changed
  • Incident commented
  • ...

The core fir_abuse plugin added the Celery dependency in FIR, so I suggest adding this notification plugin as a core plugin into FIR as fir_notifications.

Would you like me to submit a PR?

@benjimons
Copy link
Contributor

+1 to this. I was looking to make something similar, it would be nice to have both "events" and "incidents" individually configurable for notifications.

@gaelmuller
Copy link
Contributor

gaelmuller commented Jan 14, 2017

We are always interested in pull requests, especially when they are in a separate plugin that people can chose to install or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants