Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New copy/variant does not list it as separate content #2697

Open
tmkarlsen opened this issue Mar 20, 2024 · 2 comments
Open

New copy/variant does not list it as separate content #2697

tmkarlsen opened this issue Mar 20, 2024 · 2 comments
Assignees
Labels
bug Something isn't working needs triage All issues that need to be triaged by repository admins

Comments

@tmkarlsen
Copy link
Member

tmkarlsen commented Mar 20, 2024

Creating a new variant/copy should make a separate piece of content
As of now, the copy/new variant is listed as part of the version history in detail view
https://hub.edlibdev.net/content/01hsdn2qd0m2c0hfajtrazj31a

To Reproduce

  1. Create a H5P content and save it
  2. Edit it and tick off "New variant" in the language section (changing language should not be necessary )
  3. Save it.
  4. Verify that a new content has been registered in ca-admin
  5. Observe that the same amount of content is listed under "My content" and that the original content has been overwritten with what should have been the new copy of it.

Expected behavior
New content should be added to "my content" and should follow the version structure, as seen backend in CA-admin.
( new content should not be listed as a version in the version history for the original content)

Screenshots
Skjermbilde 2024-03-20 kl  11 28 07

Skjermbilde 2024-03-20 kl  11 28 16

@tmkarlsen tmkarlsen added bug Something isn't working needs triage All issues that need to be triaged by repository admins labels Mar 20, 2024
@tmkarlsen
Copy link
Member Author

tmkarlsen commented May 29, 2024

A new test shows that the copy is separated backend (ca-admin), but the hub combines the two into one version and only shows the last version:
No changes were made to the new copy on save, I only ticked off "Make new variant".

Image

Image

@emmachughes
Copy link
Member

The 'make variant' toggle has no effect in Edlib 3. As discussed previously, it is to be removed in favour of making copies on the hub side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage All issues that need to be triaged by repository admins
Projects
Status: 🔖 Prioritized and ready
Development

No branches or pull requests

2 participants