Skip to content
This repository has been archived by the owner on May 22, 2024. It is now read-only.

[package-json-lint] Add a package-json-lint rule for ensuring that development dependencies that are not declared as dependencies #695

Closed
ryanthemanuel opened this issue Aug 16, 2021 · 0 comments · Fixed by #710

Comments

@ryanthemanuel
Copy link
Contributor

ryanthemanuel commented Aug 16, 2021

Story

Description

As a consumer of a component, I'd like to ensure that development dependencies are not declared as regular dependencies

Motivation

So that consumers of my component don't need to have any unnecessary peer dependencies met and don't have unnecessary dependencies installed

Definition of Done

We'll know we're done when the rule is created and defaults are specified in package-json-lint-config-terra

Additional Notes

This rule should not apply for devModules (see this issue for how that will be specified: #696).

For now we should maintain a list of dependencies that are warranted to be "development dependencies", we should go through all of our components for our dev dependencies and start with that list (things like babel, webpack, terra-dev-site, etc.)

@ryanthemanuel ryanthemanuel added this to the Backlog milestone Aug 19, 2021
@ryanthemanuel ryanthemanuel changed the title [package-json-lint] Add a package-json-lint rule for ensuring that dependencies that are not declared as dependencies [package-json-lint] Add a package-json-lint rule for ensuring that development dependencies that are not declared as dependencies Aug 24, 2021
@pranav300 pranav300 self-assigned this Sep 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.