[terra-functional-testing] Tests are not executed in all the browsers provided by the BROWSERS env variable

[benbcai]

Bug Report

Description

When the BROWSERS env variable (passed from Jenkins) contains white spaces between each browsers, browsers after the first one are not parsed correctly and excluded from the test run.

Note: Setting browsers using the --browsers CLI option works as expected. This is an issue only when setting browsers using the BROWSERS env variable.

Steps to Reproduce

1. Identify a project that has the useSeleniumGrid option set to true and does NOT have the browsers option set in Jenkinsfile. When no browsers are provided and build using selenium grid, this will default to build in chrome, firefox, and IE.
2. Build the project in Jenkins.
3. Go to the Test step and notice that the tests are ran only in chrome but not in firefox or IE.

Additional Context / Screenshots

1. The BROWSERS env set in Jenkins looks like this - BROWSERS=[chrome, firefox, ie] (notice the space before firefox and ie)
2. When each browser is split into the array the white space between each browsers is not removed. As a result, the browsers array ends up like [ 'chrome', ' firefox', ' ie' ] (notice the space before firefox and ie).
3. Due to the extra space getCapabilities would fail to match and add firefox and ie as browser capabilities.

Expected Behavior

Possible Solution

Environment

• Component Name and Version:
• Browser Name and Version:
• Node/npm Version: [e.g. Node 8/npm 5]
• Webpack Version:
• Operating System and version (desktop or mobile):

@ Mentions