This repository has been archived by the owner on May 22, 2024. It is now read-only.
[terra-functional-testing] Add cloudRegion as a screenshot directory namespace
#660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4584a74.
…update tests to correctly initialize with options.
yuderekyu
requested review from
dkasper-was-taken,
mjhenkes,
ryanthemanuel and
tbiethman
as code owners
pranav300
approved these changes
May 27, 2021
benbcai
approved these changes
May 27, 2021
tbiethman
approved these changes
May 28, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for the
cloudRegionnamespace when generating a screenshot. This will prevent screenshot overwrites within a orion-full-stack-testing context, if test runs differ per cloudRegionCloses #657