Skip to content

Fix resolving subaddresses #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cereal2nd merged 4 commits into from
Dec 21, 2025
Merged

Fix resolving subaddresses #154

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
95ea1e7
Add module type request
brefra Dec 20, 2025
aef9e3f
Update comment
brefra Dec 21, 2025
79d6b4e
Save and retrieve subaddresses from cache
brefra Dec 21, 2025
8f44e14
Do not save to cache
brefra Dec 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion velbusaio/module.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@
ModuleStatusPirMessage,
)
from velbusaio.messages.module_status_request import ModuleStatusRequestMessage
from velbusaio.messages.module_type_request import ModuleTypeRequestMessage
from velbusaio.messages.push_button_status import PushButtonStatusMessage
from velbusaio.messages.raw import MeteoRawMessage, SensorRawMessage
from velbusaio.messages.read_data_from_memory import ReadDataFromMemoryMessage
Expand Down Expand Up @@ -251,9 +252,11 @@ def __str__(self) -> str:
return self.__repr__()

def to_cache(self) -> dict:
d = {"name": self._name, "channels": {}}
d = {"name": self._name, "channels": {}, "sub_addresses": {}}
for num, chan in self._channels.items():
d["channels"][num] = chan.to_cache()
for num, address in self._sub_address.items():
d["sub_addresses"][num] = address
return d

def get_address(self) -> int:
Expand Down Expand Up @@ -613,6 +616,17 @@ async def load(self, from_cache: bool = False) -> None:
self._name = cache["name"]
else:
await self.__load_memory()

# load the sub addresses from cache if it's available
if (self._use_cache or from_cache) and "sub_addresses" in cache:
for num, addr in cache["sub_addresses"].items():
self._sub_address[int(num)] = int(addr)
else:
# Submit ModuleType request to trigger discovery of sub addresses.
# Do not cache immediately here: sub addresses are populated asynchronously
# when the response is handled; caching now could store an empty mapping.
await self._writer(ModuleTypeRequestMessage(self._address))

# load the module status
# await self._request_module_status()
# load the channel names
Expand Down
Loading