Fix resolving subaddresses#154
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where subaddresses of cached modules were not being properly discovered, causing "list index out of range" errors. The fix adds a ModuleTypeRequest message during module loading to explicitly trigger subaddress discovery.
Key changes:
- Import
ModuleTypeRequestMessageto enable subaddress discovery requests - Send ModuleTypeRequest during
load()method to ensure subaddresses are discovered regardless of cache state
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
cereal2nd
requested changes
Dec 21, 2025
brefra
force-pushed
the
Fix-SubAddresses
branch
2 times, most recently
from
3fbdd01 to
6995338
Compare
brefra
force-pushed
the
Fix-SubAddresses
branch
from
6995338 to
79d6b4e
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
cereal2nd
approved these changes
Dec 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sub addresses of a cached module are missing. This PR adds the discovery of sub addresses.
This PR will fix
list index out of rangeerrors like mentioned in #156975 at home-assistant/core