Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRY up duplicate transport code #386

Closed
c24t opened this issue Nov 6, 2018 · 2 comments
Closed

DRY up duplicate transport code #386

c24t opened this issue Nov 6, 2018 · 2 comments
Assignees
Labels

Comments

@c24t
Copy link
Member

c24t commented Nov 6, 2018

#256 copied the transports package from trace/ into common/. We now have two nearly-identical copies of the code. See common/transports and trace/exporters/transports.

Before merging these we need to check that the new default options for stats transports will work for tracing.

@ocervell
Copy link
Contributor

Any plans to merge the trace/exporters/transport and common/transports soon ? How do we ensure this will not break backwards compatibility ?

@c24t
Copy link
Member Author

c24t commented Nov 16, 2018

@ocervell no specific plans, and we have some work to do to make sure the tests are sufficient to prove that we don't break backwards compatibility. Luckily the code is almost identical in both places.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants