Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

stop ignoring errors while processing metrics. #236

Merged
merged 1 commit into from
Nov 7, 2019

Conversation

rghetia
Copy link
Contributor

@rghetia rghetia commented Nov 7, 2019

fixes #235

@songy23
Copy link
Contributor

songy23 commented Nov 7, 2019

Please fix the CI failure.

@codecov-io
Copy link

Codecov Report

Merging #236 into master will decrease coverage by 0.35%.
The diff coverage is 30.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #236      +/-   ##
==========================================
- Coverage   73.72%   73.36%   -0.36%     
==========================================
  Files          15       15              
  Lines        1625     1637      +12     
==========================================
+ Hits         1198     1201       +3     
- Misses        350      358       +8     
- Partials       77       78       +1
Impacted Files Coverage Δ
metrics.go 78.47% <30.76%> (-2.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9366d36...ea3ef50. Read the comment docs.

Copy link
Contributor

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OnError function is not called when ExportMetrics api is used to export.
4 participants