Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

Rename metrics_test_utils.go to avoid dependency on testing package. #233

Merged
merged 2 commits into from
Nov 7, 2019

Conversation

ascherkus
Copy link
Contributor

Any code depending on the exporter would pull in the testing package (noticable
when listing flags).

Rename file to metrics_utils_test.go to limit inclusion to test binaries.
Verified by running go list -deps . | grep testing.

Any code depending on the exporter would pull in the testing package (noticable
when listing flags).

Rename file to metrics_utils_test.go to limit inclusion to test binaries.
Verified by running `go list -deps . | grep testing`.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@ascherkus
Copy link
Contributor Author

Didn't see the issue but this does indeed fix #229

@rghetia
Copy link
Contributor

rghetia commented Nov 7, 2019

@ascherkus can you please sign the CLA?

@ascherkus
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Nov 7, 2019
@rghetia rghetia requested review from songy23 and removed request for dinooliva November 7, 2019 18:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants