Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-migration step to migrate script #171

Closed
3 tasks done
Tracked by #169
alecps opened this issue Jun 25, 2024 · 2 comments
Closed
3 tasks done
Tracked by #169

Add pre-migration step to migrate script #171

alecps opened this issue Jun 25, 2024 · 2 comments
Assignees

Comments

@alecps
Copy link

alecps commented Jun 25, 2024

The rsync command currently used in the celo-migrate script can be run as part of the pre-migration step, without applying any transformations or state changes on top of it. It seems the --update and --delete flags can be used to only rsync new data during the actual migration.

Tasks

@piersy
Copy link

piersy commented Jul 1, 2024

Hey @alecps what's the reason for running this separately in a pre-migrate step?

@alecps
Copy link
Author

alecps commented Jul 19, 2024

@piersy the reason is that the full migration will apply transformations to the newDb (as part of the non-ancients and state migration steps). These transformations will affect what the rsync command detects as differences between the old and new dbs the second time it is run, causing it to copy over the wrong data and corrupt the newDb. So, we want a way to run only the ancients migration and rsync commands (the only steps that can be paused and resumed) together ahead of time in a "pre-migration". The pre-migration step is still part of the full migration, where it will only apply to any newly frozen blocks or other updates in oldDB since the last pre-migration was run.

Open to other ideas on how to structure this if you have any!

@piersy piersy changed the title Have rsync run as part of pre-migration Add pre-migration step to migrate script Jul 25, 2024
@alecps alecps closed this as completed Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants