-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintain a tokenlist by chainId #64
Comments
@aaronmgdr if we change celo.tokenlist.json it can affect all the user calling the list as it is. Do you have a preference here for which option we should do?
|
I'm not entirely sure what the benefits of splitting the list is? Filtering values programmatically by chainId is easy enough and the list isn't big at all, so download size doesn't matter here. I'm strongly in favour of option 3 |
If separate lists per chain is the standard we will follow that custom |
Current implementation of the tokenlist includes tokens from both chainId 42220 and 44787.
Please split the list into two different lists, one for each chainId.
This will maintain tokenlist best practice structure where each list is dedicated for a dedicated chainId.
The text was updated successfully, but these errors were encountered: